290 desktop client should not force user to setup a local core #324
Conversation
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Kevin Huang <44907675+Ynng@users.noreply.github.com>
|
We need to disable this popup in this usecase (tauri & localcore not setup & on dashboard page looking at external cores)
|
|
This page might benefit from a "back" button
|
|
This button still says "setup" even if the local core is already setup. We should remove this button, or change the text to be more general like "use local core".
|
which page should we go back to? in this issue there are 2 ways of going to that page, from this one: and this one: |
could you clarify on the exact steps you did to get this? i can't seem to get to this popup |
|
Regarding back button, I think the default browser "navigate backward" behavior might be enough.
|
| type="button" | ||
| iconRight={faArrowLeft} | ||
| label="Back" | ||
| onClick={navigateBack} | ||
| /> */} | ||
| onClick={() => { |
There was a problem hiding this comment.
can this be shortened to onClick={navigateBack}?
| return; | ||
| } | ||
|
|
||
| // if (coreList.length > 0) { |
There was a problem hiding this comment.
why is this redirect commented out?
Description
Added way for users to skip local core setup in initial page load in Tauri:
Added extra button in core select page in Tauri for local setup later on - this works by selecting the first option that shows up in Tauri, which might not work in all cases.
Type of change
Note: make sure your files are formatted with rust-analyzer