-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant code to set the device on the LightningModule #19877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
williamFalcon,
carmocca and
justusschock
as code owners
May 16, 2024 12:05
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19877 +/- ##
==========================================
- Coverage 84% 53% -31%
==========================================
Files 426 418 -8
Lines 35237 35080 -157
==========================================
- Hits 29505 18647 -10858
- Misses 5732 16433 +10701 |
lantiga
approved these changes
May 17, 2024
carmocca
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes some lines that are no longer needed.
They were originally added in #12985, but then later we decided to set the device earlier in the Trainer: #18021. There are tests for this.
📚 Documentation preview 📚: https://pytorch-lightning--19877.org.readthedocs.build/en/19877/
cc @Borda @justusschock @awaelchli