Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy dependencies in src/lightning/pytorch #19841

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

Peiffap
Copy link
Contributor

@Peiffap Peiffap commented May 2, 2024

What does this PR do?

Removes dependency on numpy in part of the codebase (src/lightning/pytorch), as mentioned in #17278.

Partially fixes #17278

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19841.org.readthedocs.build/en/19841/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 2, 2024
@Peiffap Peiffap changed the title Remove numpy mentions in src/lightning/pytorch Remove numpy dependencies in src/lightning/pytorch May 2, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (fd86ea7) to head (737fda6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19841      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         426      418       -8     
  Lines       35256    35103     -153     
==========================================
- Hits        29679    18695   -10984     
- Misses       5577    16408   +10831     

@awaelchli awaelchli added the community This PR is from the community label Jun 4, 2024
@awaelchli awaelchli added this to the 2.3 milestone Jun 4, 2024
@awaelchli awaelchli merged commit 785f15d into Lightning-AI:master Jun 4, 2024
92 of 93 checks passed
@awaelchli
Copy link
Member

Thanks a lot for your recent PRs @Peiffap!

@Peiffap Peiffap deleted the remove_np branch June 5, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration community This PR is from the community pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants