Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _choose_auto_accelerator to staticmethod #19822

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

fedebotu
Copy link
Contributor

@fedebotu fedebotu commented Apr 28, 2024

What does this PR do?

This is a minor change. It sets the _choose_auto_accelerator as a staticmethod since no attribute of self is used.

This can also be useful for other libraries to check whether hardware accelerators are available via _AcceleratorConnector._choose_auto_accelerator() without the need to reimplement this function!

Before submitting
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19822.org.readthedocs.build/en/19822/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 28, 2024
@awaelchli awaelchli added the community This PR is from the community label Jun 5, 2024
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 5, 2024
@awaelchli awaelchli changed the title [Minor] set _choose_auto_accelerator to staticmethod Set _choose_auto_accelerator to staticmethod Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59%. Comparing base (5e0e02b) to head (f90a79a).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #19822     +/-   ##
=========================================
- Coverage      84%      59%    -25%     
=========================================
  Files         424      421      -3     
  Lines       34698    35160    +462     
=========================================
- Hits        29153    20758   -8395     
- Misses       5545    14402   +8857     

@awaelchli awaelchli added this to the 2.3 milestone Jun 5, 2024
@awaelchli
Copy link
Member

@fedebotu As a clean up, LGTM, thanks!

This can also be useful for other libraries to check whether hardware accelerators are available via _AcceleratorConnector._choose_auto_accelerator() without the need to reimplement this function!

That's great if it's helpful to you. However I would not rely on this internal method. Protected marked methods are internal to Lightning and can change anytime without warning, potentially breaking your code.

@awaelchli awaelchli merged commit 19f0fb9 into Lightning-AI:master Jun 5, 2024
118 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants