Fix save_last type annotation for ModelCheckpoint
#19808
Merged
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariovas3
force-pushed
the
bugfix/#19799_model-checkpoint-save_last-cli
branch
from
a70f49b
to
4feb7ff
Compare
mariovas3
force-pushed
the
bugfix/#19799_model-checkpoint-save_last-cli
branch
from
4feb7ff
to
ad806f4
Compare
mariovas3
requested review from
awaelchli,
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
mariovas3
force-pushed
the
bugfix/#19799_model-checkpoint-save_last-cli
branch
2 times, most recently
from
9fc2954
to
2f8b53c
Compare
… jsonargparse can correctly parse inputs such as true, false, etc... before this change jsonargparse gave errors complaining that strings like 'true' or 'false' were given when the annotation expected Optional[Literal[True, False, 'link']]; this is in contrast to most other bool parameters in the ModelCheckpoint callback's constructor. I also added a test in tests/test_pytorch/checkpointing/test_model_checkpoint.py::test_save_last_cli
mariovas3
force-pushed
the
bugfix/#19799_model-checkpoint-save_last-cli
branch
from
2f8b53c
to
aca427f
Compare
|
The PR is pretty compact - few modifications in 2 files. The PR has been ready to review for the last 3 weeks. It passes all available tests. Please someone review it, so I can close the issue and the PR. |
awaelchli
changed the title
save_last type annotation for ModelCheckpoint
awaelchli
added
callback: model checkpoint
community
awaelchli
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
@mariovas3 That's a great fix, thanks for sending the PR and including a test as well!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19808 +/- ##
==========================================
- Coverage 84% 53% -31%
==========================================
Files 426 418 -8
Lines 35264 35111 -153
==========================================
- Hits 29553 18703 -10850
- Misses 5711 16408 +10697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #19799
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19808.org.readthedocs.build/en/19808/