Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-proxy): Fix Cohere breaks with model parameter in body; Fix OpenAI token counting for function requests; Fix user sending own-model parameter #13000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented May 8, 2024

Summary

Minor fix rollup from RC2, for function calling fixes and other broken AI config checks.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4596

@tysoekong
Copy link
Contributor Author

Happy 13,000th pull request!!

@tysoekong tysoekong force-pushed the fix/ai_proxy_rc2_feedback branch 3 times, most recently from 3cd4e1a to 7bef31f Compare June 3, 2024 10:00
@fffonion
Copy link
Contributor

fffonion commented Jun 4, 2024

changes look fine, the commit message as well the linked ticket description should be more descriptive, let's describe what's actually being fixed instead of RC2 feedback.

@tysoekong tysoekong changed the title fix(ai-proxy): RC2 feedback fix(ai-proxy): Fix Cohere breaks with model parameter in body; Fix OpenAI token counting for function requests; Fix user sending own-model parameter Jun 5, 2024
@Kong Kong deleted a comment from ttyS0e Jun 5, 2024
fix(ai-proxy): user cannot select their own model if one is defined
fix(ai-proxy): plugin config should own the tuning parameters
fix(ai-proxy): correct model check precedence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants