-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display status of sending request steps - INS-3635 #7382
Open
ihexxa
wants to merge
10
commits into
develop
Choose a base branch
from
feat-send-progress
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+219
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihexxa
changed the title
feat: display status of sending request steps
feat: display status of sending request steps - INS-3635
May 7, 2024
ihexxa
force-pushed
the
feat-send-progress
branch
from
May 21, 2024 08:23
0d25008
to
8753e7b
Compare
ihexxa
force-pushed
the
feat-send-progress
branch
from
May 29, 2024 02:46
c05f080
to
3afb742
Compare
CurryYangxx
reviewed
Jun 3, 2024
}; | ||
|
||
watchRequestTiming(executionId, cb); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dose this useEffect needs a second dependency param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, 2 deps are added.
ihexxa
force-pushed
the
feat-send-progress
branch
from
June 4, 2024 03:08
f0c4f59
to
135544e
Compare
jackkav
reviewed
Jun 4, 2024
jackkav
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ref: INS-3821, INS-3635