-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce implicit cast compilation warnings #993
Open
jeroenbakker-atmind
wants to merge
1
commit into
KhronosGroup:main
Choose a base branch
from
jeroenbakker-atmind:dynamic_line_rasterization/fix-xcode-build-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reduce implicit cast compilation warnings #993
jeroenbakker-atmind
wants to merge
1
commit into
KhronosGroup:main
from
jeroenbakker-atmind:dynamic_line_rasterization/fix-xcode-build-warnings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuessenbach
previously approved these changes
Mar 20, 2024
jeroenbakker-atmind
force-pushed
the
dynamic_line_rasterization/fix-xcode-build-warnings
branch
from
March 21, 2024 17:53
a12a7d5
to
93a8a8a
Compare
I had to force push as the CLA didn't like using not default email address in commit. |
jeroenbakker-atmind
changed the title
Fix compilation warning deteced on XCode
WIP: Fix compilation warning deteced on XCode
Apr 8, 2024
jeroenbakker-atmind
changed the title
WIP: Fix compilation warning deteced on XCode
WIP: Fix compilation warning detected on XCode
Apr 8, 2024
jeroenbakker-atmind
force-pushed
the
dynamic_line_rasterization/fix-xcode-build-warnings
branch
from
May 15, 2024 07:50
93a8a8a
to
986d8fb
Compare
jeroenbakker-atmind
changed the title
WIP: Fix compilation warning detected on XCode
Reduce compilation warning (implicit casts)
May 15, 2024
jeroenbakker-atmind
changed the title
Reduce compilation warning (implicit casts)
Reduce implicit cast compilation warnings
May 15, 2024
SaschaWillems
approved these changes
May 19, 2024
gary-sweet
approved these changes
May 30, 2024
gpx1000
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing implicit casts with static casts.
This PR doesn't do any functional or code flow changes, only making casts explicit.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: