Make deepcopy_internal inferrable for BigInt and BigFloat
#54496
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM with some |
JeffBezanson
approved these changes
May 17, 2024
fingolfin
approved these changes
May 18, 2024
LilithHafner
added
status:merge me
|
Thanks @LilithHafner for adding tests. |
|
Yes. Bugfixes and simple, unobjectionable performance improvements are backportable. This is the latter. |
LilithHafner
added
backport 1.11
KristofferC
pushed a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com> (cherry picked from commit c28a9de)
KristofferC
pushed a commit
that referenced
this pull request
May 23, 2024
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com> (cherry picked from commit c28a9de)
fingolfin
pushed a commit
that referenced
this pull request
May 23, 2024
Same as #54496 for some more methods. I added some more testcases than the changed methods. For `SimpleVector`, I don't know how to construct an instance for a testcase. This could be backported to 1.11.
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this is not inferrable/typestable when looking at a
deepcopy_internalimplementation of one of my own types using JET.data(a)is here a BigInt (and julia can infer this in 1.10), but the type ofdeepcopy_internal(data(a), dict)gets inferred asAny, thus leading to dynamic dispatch in the surrounding code.This PR fixes this.