IntelliJ Platform Gradle Plugin: JetBrains Runtime #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's some duplication with existing page that must be avoided. |
YannCebron
requested changes
May 14, 2024
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
| The IntelliJ Platform Gradle Plugin requires JetBrains Runtime (JBR) for running IDE locally, testing, or performing other actions that require Java Runtime adjusted by JetBrains. | ||
|
|
||
| For the best experience, it is recommended to rely on JetBrains Runtime bundled with the IntelliJ Platform used for development. | ||
| If one is not available, i.e., when targeting IntelliJ Platform snapshot or nightly releases, there are other ways available for providing JetBrains Runtime in a required version or variant. |
There was a problem hiding this comment.
Since when do snapshot releases not contain JBR?
There was a problem hiding this comment.
I don't exactly remember, but 2022.3.3 already doesn't have it.
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Show resolved
Hide resolved
karollewandowski
requested changes
May 14, 2024
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
| ## Obtained with IntelliJ Platform from Maven | ||
|
|
||
| If the IntelliJ Platform is resolved with the IntelliJ Maven Repository instead of JetBrains Download CDN, it has no JetBrains Runtime (JBR) bundled. | ||
| In such a case, it is necessary to provide it in the suitable version with the version read from the <path>[intellijPlatform]/dependencies.txt</path> file. |
There was a problem hiding this comment.
[intellijPlatform]/dependencies.txt is unclear to me. Is it the IDE home directory? Maybe an example could help?
There was a problem hiding this comment.
It's the IDE home directory but in the most of cases, it's long, ugly and should not be directly referred.
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
...s/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_jetbrains_runtime.md
Outdated
Show resolved
Hide resolved
…rDirectory` to `SandboxAware.sandboxDirectory`
…ation.hasModulePlugin`
…tellij_platform_gradle_plugin_jetbrains_runtime.md Co-authored-by: Karol Lewandowski <karol.lewandowski@jetbrains.com>
…tellij_platform_gradle_plugin_jetbrains_runtime.md Co-authored-by: Karol Lewandowski <karol.lewandowski@jetbrains.com>
…tellij_platform_gradle_plugin_jetbrains_runtime.md Co-authored-by: Karol Lewandowski <karol.lewandowski@jetbrains.com>
…tellij_platform_gradle_plugin_jetbrains_runtime.md Co-authored-by: Karol Lewandowski <karol.lewandowski@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.