New framework for displaying images in rendered documentation #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-bel
force-pushed
the
adaptive-images
branch
3 times, most recently
from
f14e68e
to
0587baa
Compare
- Supports raster and SVG images - Re-rasterizes SVG images when view dimensions are changed - Supports changes tracking of local files via VirtualFileSystem; automatically reloads images if they are changed - Supports base64 data urls DocRenderer and DocumentationEditorPane now properly handle content height change due to images being loaded lazily Fixes IDEA-256643
alex-bel
force-pushed
the
adaptive-images
branch
from
0587baa
to
1b0081e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocRenderer and DocumentationEditorPane now properly handle content height change due to images being loaded lazily
Fixes IDEA-256643
Some screenshots explaining visual changes
Code editor and pop-up documentation pane - no fix:
Code editor and pop-up documentation pane - with fix:
SVGs in comments are rendered and there are no scaling artifacts in image in pop-up documentation pane
Documentation panels side-by side (left - with fix, right - without fix). Notice scaling artifacts on the rand hand side panel
