Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logprobs output #1561

Merged
merged 2 commits into from
May 24, 2024
Merged

fix logprobs output #1561

merged 2 commits into from
May 24, 2024

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented May 8, 2024

Motivation

The outputs of turbomind uses the same memory and _get_logprobs takes sequence_length as right interval.

Currently, the copy of logprob_xxx comes after sequence_length, which has a probability of illegal access to logprob_xxx

@lvhan028 lvhan028 requested a review from lzhangzz May 8, 2024 09:03
Copy link
Collaborator

@lzhangzz lzhangzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irexyc irexyc changed the title fix logprobs right interval fix logprobs output May 23, 2024
@lvhan028 lvhan028 merged commit 68a3c1d into InternLM:main May 24, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants