-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove chat template config in turbomind engine #1161
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tesed with
- lmdeploy chat turbomind internlm2-chat-7b w/wo --chat-template
- pipeline of internlm2-chat-7b w/wo --chat-template
- api_server with chat-template
chat_template (str): user defined chat template | ||
kwargs (dict): unused args | ||
""" # noqa: E 501 | ||
print('unused kwargs', kwargs, sep='') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有必要打印么?
cap: str = 'chat', | ||
tp: int = 1, | ||
max_batch_size: int = 128, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_batch_size 感觉不用作为参数
tm_model = tm.TurboMind.from_pretrained( | ||
model_path, | ||
engine_cfg = TurbomindEngineConfig( | ||
max_batch_size=max_batch_size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_batch_size=1
Motivation
Align to torch engine, remove chat_template_mdoel in turbomind engine.
BC-breaking
When using turbomind engine directly, user needs to explicitly specify EngineGenerationConfig and set stop_words