Add svgo as npm dependency and set up npm script to run it #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldyrious
changed the title
waldyrious
force-pushed
the
svgo-dependency
branch
from
09fe332
to
22f7a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99. This allows making the svgo dependency explicit and locked to a working version, while also simplifying the commands for contributing to the project.
svgonpm install -g svgonpm installsvgosvgo ./flags --recursive --config=svgo.config.jsnpm run svgoI've updated the instructions in the README, taking care to describe what's going on at each step so there's no mysterious magic happening behind the scenes for those who are not familiar with Node.js projects.
(Btw, we should probably mention in the README that Node.js is required for contributing, sinceUpdate: done.svgois a Node.js project — wdyt @HatScripts?)