-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i231] Old messages are read by newly added member #5212
Draft
kanat
wants to merge
4
commits into
develop
Choose a base branch
from
xml-message-details
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanat
commented
Mar 20, 2024
Comment on lines
+881
to
+886
if (member?.createdAt?.after(lastRead) == true) { | ||
// If the member was added after the last read, we consider it as a freshly added member. | ||
return true | ||
} | ||
// If the difference between the member's creation and the last read is less than the threshold, we consider it | ||
// as a freshly added member. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix N1
kanat
commented
Mar 20, 2024
@@ -758,9 +758,11 @@ public class MessageListController( | |||
val groupedMessages = mutableListOf<MessageListItemState>() | |||
val membersMap = members.associateBy { it.user.id } | |||
val sortedReads = reads | |||
.filter { it.user.id != currentUser?.id && !it.belongsToFreshlyAddedMember(membersMap) } | |||
.filter { | |||
it.user.id != currentUser?.id && membersMap.contains(it.user.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix N2
kanat
commented
Mar 20, 2024
Comment on lines
811
to
818
sortedReads.filter { | ||
it.lastRead.after(messageCreatedAt) | ||
&& membersMap[it.user.id]?.createdAt?.before(messageCreatedAt) == true | ||
} | ||
} ?: emptyList() | ||
|
||
val isMessageRead = messageReadBy.isNotEmpty() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix N3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
Closes:
鈽戯笍Contributor Checklist
General
develop
branchCode & documentation
鈽戯笍Reviewer Checklist
馃帀 GIF
Please provide a suitable gif that describes your work on this pull request