Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fem: Improve constraint section print #14046

Merged
merged 2 commits into from
May 20, 2024

Conversation

marioalexis84
Copy link
Member

@marioalexis84 marioalexis84 commented May 16, 2024

  • Add Variable property to select CalculiX section print key. (Drag Stress not yet supported)
  • Add symbol to the view provider.
  • Update task panel.

@FEA-eng

@github-actions github-actions bot added the WB FEM Related to the FEM Workbench label May 16, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented May 16, 2024

Nice, recently I've noticed that this constraint has an empty SectionPrint parameter panel and I was going to suggest that it should be removed but you made a good use of it as more options may now be supported since heat flux will be available in thermal analyses.

I would just like to suggest renaming Section Load (suggesting external loads) to something like Section Forces (even if moments are included as well) or Section Forces and Moments. When it comes to Drag Stresses, we may even omit them from the selection and leave only the other 2 options.

@marioalexis84
Copy link
Member Author

Enum changed to Section Force.
I prefer not to omit drag stress even if it is not used. If we add support for fluids in the future, a workaround is needed to update the old section print objects with the new value. It could be added to the documentation that the option is not yet supported.

@FEA-eng
Copy link
Contributor

FEA-eng commented May 16, 2024

I prefer not to omit drag stress even if it is not used. If we add support for fluids in the future, a workaround is needed to update the old section print objects with the new value. It could be added to the documentation that the option is not yet supported.

Ok, I guess that we can keep one not yet supported property value.

@chennes chennes merged commit 33e4a5b into FreeCAD:main May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants