[Sketcher] Change HeadlightIntensity entering and exiting Edit Mode #14013
Conversation
github-actions
bot
added
Core
|
This is vastly better than permanently applying a lower headlight intensity value! |
src/Gui/View3DSettings.cpp
Outdated
| @@ -69,6 +69,14 @@ int View3DSettings::stopAnimatingIfDeactivated() const | |||
|
|
|||
| void View3DSettings::applySettings() | |||
| { | |||
| // Check if Sketcher Edit Mode exited cleanly | |||
| int overMaxHeadlightIntensity = 101; | |||
| "User parameter:BaseApp/Preferences/View"); | ||
|
|
||
| // This should not be needed but just incase | ||
| int overMaxHeadlightIntensity = 101; |
There was a problem hiding this comment.
Can we eliminate this duplication?
|
Hi there, a bit late on this one but I don't really understand it. |
|
@Syres916 with the solution implemented it's too dark to see for light themes: @FreeCAD/design-working-group FYI |
|
Morning @0penBrain , the goal for me is quite simple, have the same user experience creating a sketch in current main as in 0.21.x branch. For the past several weeks the situation with default settings has been completely unacceptable, see the screenshot in the issue description of #13989 How it's fixed as long as it doesn't involve iterating through all the objects of a document is irrelevant to me. Completely open to tested solutions though I have to say that Themes shouldn't dictate core code, that is the tail wagging the dog, IMHO. |
|
@Syres916 yes agreed. But now also images are dark and that is a problem when tracing sketches. Also trying to select external geometry as reference is now was harder as all has become dark. This has nothing to do with themes. |
|
If you're not happy with the change revert the PR. |
I wouldn't do it as long as a new fix is ready. The current behavior is much better than before the PR when basic geometry was invisible in all sketches based on the existing geometry. |
|
I don't know the technical details of how Coin works, but here is what Blender can do: you can disable light source for a particular object. People use that frequently when they need to insert video footage of still images into 3D scenes and display them in original fidelity. Here is a fairly recent tutorial how to disable a light source for an object: https://www.youtube.com/watch?v=WacqnIJj4Jw So maybe disable light source for all imported images and show them 'as is', while displaying geometry with reduced highlight intensity? |
Handle the situation where the user has a hard crash in Edit Mode by resetting parameter on entering 3D view.
Fixes #13989
With PR applied to default material:
versus current situation of being unable to determine where the sketch geometry is against the object behind.