Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measurement icons #14011

Merged
merged 4 commits into from
May 20, 2024
Merged

Add measurement icons #14011

merged 4 commits into from
May 20, 2024

Conversation

hlorus
Copy link
Contributor

@hlorus hlorus commented May 14, 2024

This PR addresses #13710

It adds icons to:

  • the labels in the 3d view
  • the elements in the tree view
  • the measurement group in the tree view

Screenshot from 2024-05-14 17-28-19

Icons by @maxwxyz

hlorus and others added 4 commits May 14, 2024 17:53
Co-Authored-By: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>
Co-Authored-By: Max Wilfinger <6246609+maxwxyz@users.noreply.github.com>
@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label May 14, 2024
@pierreporte
Copy link

This is great but the inertia icon is not that clear at first sight. Why not a spinning top ?

image

@FEA-eng
Copy link
Contributor

FEA-eng commented May 14, 2024

@hlorus Btw. do you plan to change the area unit display from cm^2 to cm2 ? I haven't seen an issue for this but I think that I've seen it somewhere among the discussions. Should I create a new issue for this?

@FEA-eng
Copy link
Contributor

FEA-eng commented May 14, 2024

This is great but the inertia icon is not that clear at first sight. Why not a spinning top ?

If it's for COG/COM then I would use the classic symbol:

COG

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 14, 2024

This is great but the inertia icon is not that clear at first sight. Why not a spinning top ?

If it's for COG/COM then I would use the classic symbol:

COG

That's used for COG/COM

@hlorus
Copy link
Contributor Author

hlorus commented May 14, 2024

@hlorus Btw. do you plan to change the area unit display from cm^2 to cm2 ? I haven't seen an issue for this but I think that I've seen it somewhere among the discussions. Should I create a new issue for this?

Yeah it's best to create an issue, otherwise it might get lost. Not sure why it's displayed that way, afaik UMF uses the standard quantity type so it should display the same way as in any other place. Are you sure it's specific to UMF?

@FEA-eng
Copy link
Contributor

FEA-eng commented May 15, 2024

Yeah it's best to create an issue, otherwise it might get lost. Not sure why it's displayed that way, afaik UMF uses the standard quantity type so it should display the same way as in any other place. Are you sure it's specific to UMF?

Thanks for the information. I'm not sure where else to check, to be honest. TechDraw displays it properly but it may not be representative. Quick measure displays it like UMF but it might be because it's based on it. I'm pretty sure you're right, I just thought that UMF annotations could use a different style in some way.

@maxwxyz maxwxyz linked an issue May 16, 2024 that may be closed by this pull request
2 tasks
@chennes chennes merged commit 53da36a into FreeCAD:main May 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement: Label should display the measurement type
5 participants