Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly: JCS selection: cones surfaces offers the cone's apex. #14009

Merged
merged 1 commit into from
May 20, 2024

Conversation

PaddleStroke
Copy link
Contributor

Cone offers the apex for JCS selection : Fixes #13958
image

@github-actions github-actions bot added the WB Assembly Related to the Integrated Assembly Workbench label May 14, 2024
@pierreporte
Copy link

Will you implement the distance parameter for this?

@PaddleStroke
Copy link
Contributor Author

I'm not sure because the distance you want is a very special case. I see no way to add it cleanly.
It would be when making a distance joint between 2 cones sharing the same angle? Then it would effectively acts as a revolute joint with an offset = distance * sin(angle)

@pierreporte
Copy link

I was referring to the situation where the two angles are identical, so only the simplest case.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 18, 2024

How will it snap the JCS to this place where nothing is? Or is it still possible to select the surface for other joints?

@PaddleStroke
Copy link
Contributor Author

The apex point is aligned with the center of mass (which was the selected position initially).
But the center of mass has no usecase. I used it because it was more or less in the center of the shape.
So switching to the apex point, I don't think we loose anything.

@chennes chennes merged commit 7c2a95b into FreeCAD:main May 20, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly: wrong mating of cones
4 participants