Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly: Add 'Angle', 'Perpendicular' and 'Parallel' joints. #14008

Merged
merged 1 commit into from
May 27, 2024
Merged

Assembly: Add 'Angle', 'Perpendicular' and 'Parallel' joints. #14008

merged 1 commit into from
May 27, 2024

Conversation

PaddleStroke
Copy link
Contributor

@PaddleStroke PaddleStroke commented May 14, 2024 •
edited

Add 'Angle', 'Perpendicular' and 'Parallel' joints.
image

@github-actions github-actions bot added the WB Assembly Related to the Integrated Assembly Workbench label May 14, 2024
@qewer33
Copy link
Contributor

qewer33 commented May 14, 2024

Shouldn't the distance joint also be grouped together (the separators) with these in the toolbar?

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 14, 2024

Shouldn't the distance joint also be grouped together (the separators) with these in the toolbar?

Agreed, they seem so similar, maybe even group them in a command group?

@PaddleStroke
Copy link
Contributor Author

Moving the separator is ok I guess. I wouldn't group them though.
I thought about grouping perpendicular and parallel under angle. But then thought otherwise. If we have them at all then it doesn't make much sense to group them.

@PaddleStroke PaddleStroke force-pushed the asm_anglejoint branch 4 times, most recently from aee1f38 to fa67286 Compare May 20, 2024 16:00
@PaddleStroke
Copy link
Contributor Author

@chennes rebased conflict solved

@FEA-eng
Copy link
Contributor

FEA-eng commented May 21, 2024

Since the previous experimental features are now exposed (which is IMO very good), will those new constraints be exposed as well? I hope so because they are essential, should be normally available in 1.0 and are working well (I tested them yesterday).

P.S. Is the pre-commit.ci failure a bad sign or nothing special?

@chennes
Copy link
Member

chennes commented May 27, 2024

This is ready for merge pending pre-commit fix.

@PaddleStroke
Copy link
Contributor Author

Precommit fixed. Apparantly black missed an extra empty line last time. Now it picked it up. Dunno why

@chennes chennes merged commit cecb965 into FreeCAD:main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PaddleStroke @qewer33 @maxwxyz @FEA-eng @chennes