-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sketcher geometry not visible on the existing 3D geometry with default colors #13989
Comments
Surely releasing before this is sorted would be a serious mistake, it'll cause way too many reports on the forum. At the very least the shininess of existing objects should be reduced while in Sketcher Edit Mode and put back on exiting Edit Mode. I personally would be happy for the shininess to be reduced overall but apparently the DWG have ruled already. |
Exactly. This issue should be added to the 1.0 release project with must have fixes once it's created. Shininess reduction or headlight direction change (suggested on the forum) seems to be the best solution ATM. |
This is related to the specularity of the underlying geometry. With no object present it's visible (depending on the background color the user has chosen) |
Ok but there's no separate issue to change this annoying default behavior in whatever way for the upcoming release? |
@maxwxyz I know this subject is your own implementation but in this instance IMHO you've overstepped in closing this so quickly. If there was an assigned developer to fix the default use for a new user then I could understand but I can't see any such assignee. It would be a fudge for the user to have to keep moving the light direction when they are modelling pitched roofs for instance. |
This is just related to the object becoming white when viewing a plane from their normal direction. |
Yes, the default sketcher geometry color is not what should be changed in this case and it doesn't always happen but it happens with the default settings for the simplest possible scenario like the one presented in the issue description. Thus, I think that it's very important to fix this and I would keep the issue open so that it's not forgotten. Maybe the easiest way would be to turn off or modify the lighting when entering a sketch. There could be a preference for this. |
Two suggestions added to the forum thread https://forum.freecad.org/viewtopic.php?t=86738&start=40 , personally the headlight auto dipping in Sketch Edit Mode is my preferred one. |
@Syres916 Thanks a lot, I also think that the second solution is the way to go. Can you send a PR? |
I can but could @obelisk79 please give a view on https://forum.freecad.org/viewtopic.php?p=759295#p759295 for the auto dipping of the headlight intensity in Sketcher Edit Mode first. |
@Syres916 I engaged the DWG on your proposed solution and while there was some back and forth about what would work best no one disagreed about this being effective and simple. I think you should go ahead and generate the PR. |
If it's easier, maybe disable specular color globally when a sketch is active? |
I'll reopen this as also images which you want to trace are reduced in visibility now with #14013 merged. |
Is there an existing issue for this?
Problem description
This was pointed out by @chrisb-github on the forum but I haven't found an issue for it. With the current defaults, the sketcher geometry is not visible when a sketch is created on the existing 3D geometry:
I think that it would be good to fix this for 1.0.
Full version info
Subproject(s) affected?
Sketcher
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: