Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketcher geometry not visible on the existing 3D geometry with default colors #13989

Open
2 tasks done
FEA-eng opened this issue May 13, 2024 · 15 comments · Fixed by #14013 · May be fixed by #14386
Open
2 tasks done

Sketcher geometry not visible on the existing 3D geometry with default colors #13989

FEA-eng opened this issue May 13, 2024 · 15 comments · Fixed by #14013 · May be fixed by #14386
Labels
Color Regarding the color handling Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench

Comments

@FEA-eng
Copy link
Contributor

FEA-eng commented May 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

This was pointed out by @chrisb-github on the forum but I haven't found an issue for it. With the current defaults, the sketcher geometry is not visible when a sketch is created on the existing 3D geometry:

circle 1

circle 2

I think that it would be good to fix this for 1.0.

Full version info

OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37213 (Git)
Build type: Release
Branch: main
Hash: 20e7deb86a8c6c2cd2378f09f8313760933f3a5c
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Polish/Poland (pl_PL)

Subproject(s) affected?

Sketcher

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Syres916
Copy link
Contributor

I think that it would be good to fix this for 1.0.

Surely releasing before this is sorted would be a serious mistake, it'll cause way too many reports on the forum. At the very least the shininess of existing objects should be reduced while in Sketcher Edit Mode and put back on exiting Edit Mode. I personally would be happy for the shininess to be reduced overall but apparently the DWG have ruled already.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented May 13, 2024

Surely releasing before this is sorted would be a serious mistake, it'll cause way too many reports on the forum. At the very least the shininess of existing objects should be reduced while in Sketcher Edit Mode and put back on exiting Edit Mode. I personally would be happy for the shininess to be reduced overall but apparently the DWG have ruled already.

Exactly. This issue should be added to the 1.0 release project with must have fixes once it's created. Shininess reduction or headlight direction change (suggested on the forum) seems to be the best solution ATM.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 13, 2024

This is related to the specularity of the underlying geometry. With no object present it's visible (depending on the background color the user has chosen)
#11166 (comment)

@maxwxyz maxwxyz closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
@FEA-eng
Copy link
Contributor Author

FEA-eng commented May 13, 2024

This is related to the specularity of the underlying geometry. With no object present it's visible (depending on the background color the user has chosen) #11166 (comment)

Ok but there's no separate issue to change this annoying default behavior in whatever way for the upcoming release?

@Syres916
Copy link
Contributor

@maxwxyz I know this subject is your own implementation but in this instance IMHO you've overstepped in closing this so quickly. If there was an assigned developer to fix the default use for a new user then I could understand but I can't see any such assignee. It would be a fudge for the user to have to keep moving the light direction when they are modelling pitched roofs for instance.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 13, 2024

This is just related to the object becoming white when viewing a plane from their normal direction.
If you have no geometry, other geometry (e.g. a shpere) or a body with different material (color, shininess) it is perfectly visible.
I think changing a default line color is just hacking around the symptoms but the root cause should be fixed instead.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented May 13, 2024

This is just related to the object becoming white when viewing a plane from their normal direction. If you have no geometry, other geometry (e.g. a shpere) or a body with different material (color, shininess) it is perfectly visible. I think changing a default line color is just hacking around the symptoms but the root cause should be fixed instead.

Yes, the default sketcher geometry color is not what should be changed in this case and it doesn't always happen but it happens with the default settings for the simplest possible scenario like the one presented in the issue description. Thus, I think that it's very important to fix this and I would keep the issue open so that it's not forgotten. Maybe the easiest way would be to turn off or modify the lighting when entering a sketch. There could be a preference for this.

@maxwxyz maxwxyz reopened this May 13, 2024
@maxwxyz maxwxyz added UI/UX Feature FR for improvements or new features WB Sketcher Related to the Sketcher Workbench Color Regarding the color handling labels May 13, 2024
@Syres916
Copy link
Contributor

Two suggestions added to the forum thread https://forum.freecad.org/viewtopic.php?t=86738&start=40 , personally the headlight auto dipping in Sketch Edit Mode is my preferred one.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented May 14, 2024

@Syres916 Thanks a lot, I also think that the second solution is the way to go. Can you send a PR?

@Syres916
Copy link
Contributor

I also think that the second solution is the way to go. Can you send a PR?

I can but could @obelisk79 please give a view on https://forum.freecad.org/viewtopic.php?p=759295#p759295 for the auto dipping of the headlight intensity in Sketcher Edit Mode first.

@obelisk79
Copy link
Contributor

@Syres916 I engaged the DWG on your proposed solution and while there was some back and forth about what would work best no one disagreed about this being effective and simple. I think you should go ahead and generate the PR.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 14, 2024

If it's easier, maybe disable specular color globally when a sketch is active?

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 28, 2024

Now we have the problem with light themes:
grafik
Shall I reopen this issue?

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 28, 2024

I'll reopen this as also images which you want to trace are reduced in visibility now with #14013 merged.
And especially when you orbit around to reference external geometry, it is too dark now to see and select the parts you want.

@maxwxyz maxwxyz reopened this May 28, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 28, 2024

The current fix also does not solve the issue when you select or preselect (hover) geometry.
It is still not visible as seen below. The face under the cursor is selected but it looks the same.
Are there any other ideas @FreeCAD/design-working-group
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Color Regarding the color handling Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench
Projects
None yet
4 participants