-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker file En version #184
base: main
Are you sure you want to change the base?
Conversation
I forgot to add this line at the beginning of the install.sh file |
@samsesh check this one https://github.com/Chasing66/x-ui |
Hello dear, can you put the expiration date for each user that is added in the next edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some spelling issues and wrong grammar, I tried to fix them all here.
Nice job by the way.
if [ $# == 0 ]; then | ||
last_version=$(curl -Ls "https://api.github.com/repos/FranzKafkaYu/x-ui/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') | ||
if [[ ! -n "$last_version" ]]; then | ||
echo -e "${red}refresh x-ui version failed,it may due to Github API restriction,please try it later${plain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting grammar:
echo -e "${red}refresh x-ui version failed, it might be due to GitHub API restriction, please again later${plain}"
echo -e "${red}refresh x-ui version failed,it may due to Github API restriction,please try it later${plain}" | ||
exit 1 | ||
fi | ||
echo -e "get x-ui latest version succeed:${last_version},begin to install..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from:
echo -e "get x-ui latest version succeed:${last_version},begin to install..."
to:
echo -e "getting x-ui latest version succeed:${last_version},begin to install..."
echo -e "get x-ui latest version succeed:${last_version},begin to install..." | ||
wget -N --no-check-certificate -O /root/x-ui-linux-${arch}-english.tar.gz https://github.com/FranzKafkaYu/x-ui/releases/download/${last_version}/x-ui-linux-${arch}-english.tar.gz | ||
if [[ $? -ne 0 ]]; then | ||
echo -e "${red}dowanload x-ui failed,please be sure that your server can access Github{plain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct spelling and grammar.
Change from:
echo -e "${red}dowanload x-ui failed,please be sure that your server can access Github{plain}"
to:
echo -e "${red}downloading x-ui failed, please make sure that your server can access GitHub{plain}"
echo -e "begin to install x-ui v$1 ..." | ||
wget -N --no-check-certificate -O /root/x-ui-linux-${arch}-english.tar.gz ${url} | ||
if [[ $? -ne 0 ]]; then | ||
echo -e "${red}dowanload x-ui v$1 failed,please check the verison exists${plain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling issues
- change dowanload to download.
- change verison to version.
- Correcting grammar.
from:
echo -e "${red}dowanload x-ui v$1 failed,please check the verison exists${plain}"
to:
echo -e "${red}downloading x-ui v$1 failed,please check exciting version${plain}"
Hello, I wanted to write the English version of the Docker file with your code and the code of @Chasing66 who wrote the Docker file.
I did this, but when it comes up, the xray doesn't work properly. I wanted to see what you think