Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration: Professional Lifecycle Experience add Enhance Search #985

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

joelcarr
Copy link
Member

@joelcarr joelcarr commented Aug 23, 2023

This PR is showing the changes in the feature branch made for @Financial-Times/professional-lifecycle-experience team to make relevant changes to enable the Enhance Search A/B test in Customer Products. This feature branch will be used to release beta versions of Page Kit to be used for the A/B test.

Any new changes should be made as PRs to this feature branch. This branch will have the same branch protections as main.

@Financial-Times/professional-lifecycle-experience will make changes will only do the following:

  • Enable the enhance search to render in the header depending on the value of a feature flag
  • Enable the ability to toggle the show state of the search bar on render

This PR will be blocked from merging into main. These changes are experimental and are owned by @Financial-Times/professional-lifecycle-experience. It is their responsibility to ensure the code works for the User Facing systems this code will be used for.

To release a beta version:

When the experiment is done

The code for this experiment will not be merged into main. Once the A/B test is concluded, we should plan fresh how to enable enhance search into the Header with the idea it is used supported in Origami.

@joelcarr joelcarr requested a review from a team as a code owner August 23, 2023 16:22
@joelcarr joelcarr marked this pull request as draft August 23, 2023 16:22
@omarbassam88 omarbassam88 marked this pull request as ready for review August 28, 2023 11:46
ibrahim-mamdouh-ft and others added 14 commits August 28, 2023 14:52
…m-ui-header-to-load-new-ui-component

feat: add new enhanced-search-suggestions to ui-header
…m-ui-header-to-load-new-ui-component

fix: integration test
…m-ui-header-to-load-new-ui-component

Eles 753 modify dotcom UI header to load new UI component
…m-ui-header-to-load-new-ui-component

backtrack: update form action and trim text
…ence-to-enhanced-from-ui-designs

Eles 794 remove reference to enhanced from UI designs
…ment-and-padding-of-flyout-menu-toms-tweak

Eles 800 adjust alignment and padding of flyout menu toms tweak
…bar-by-default-on-homepage-based-on-ammit-flag

Eles 701 show search bar by default on homepage based on ammit flag
@joelcarr joelcarr marked this pull request as draft September 12, 2023 08:54
egargan-ft and others added 14 commits September 21, 2023 15:46
…quities-headings-not-showing-in-flyout

fix: add Topics and equities
…l-enhance-search-collaboration

include o-loading, o-message into styles
4.0.0 to 6.0.0 only updates n-topic-search's node version to 18, and
updates n-express to 27.4.0.

6.1.0 makes a slight improvement to the search dropdown component, to
prevent unnecessary requests to the API that provides the topics and
securities data.
…ey-event-fix

Update n topic search key event fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants