-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaboration: Professional Lifecycle Experience add Enhance Search #985
Draft
joelcarr
wants to merge
40
commits into
main
Choose a base branch
from
CPP-1662-professional-enhance-search-collaboration
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Collaboration: Professional Lifecycle Experience add Enhance Search #985
joelcarr
wants to merge
40
commits into
main
from
CPP-1662-professional-enhance-search-collaboration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-ui-header-to-load-new-ui-component feat: add new enhanced-search-suggestions to ui-header
…m-ui-header-to-load-new-ui-component fix: integration test
…m-ui-header-to-load-new-ui-component Eles 753 modify dotcom UI header to load new UI component
…m-ui-header-to-load-new-ui-component backtrack: update form action and trim text
…ence-to-enhanced-from-ui-designs Eles 794 remove reference to enhanced from UI designs
…ment-and-padding-of-flyout-menu-toms-tweak Eles 800 adjust alignment and padding of flyout menu toms tweak
…bar-by-default-on-homepage-based-on-ammit-flag Eles 701 show search bar by default on homepage based on ammit flag
Fix search url
…behaviour fix: flyout menu behavior
…-in-search-page-header fix: link myFt & FT logo to navigation Options
Fix minor UI bugs
…quities-headings-not-showing-in-flyout fix: add Topics and equities
fix: address latest QA findings
…l-enhance-search-collaboration include o-loading, o-message into styles
4.0.0 to 6.0.0 only updates n-topic-search's node version to 18, and updates n-express to 27.4.0. 6.1.0 makes a slight improvement to the search dropdown component, to prevent unnecessary requests to the API that provides the topics and securities data.
…ey-event-fix Update n topic search key event fix
Sync with main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is showing the changes in the feature branch made for @Financial-Times/professional-lifecycle-experience team to make relevant changes to enable the Enhance Search A/B test in Customer Products. This feature branch will be used to release beta versions of Page Kit to be used for the A/B test.
Any new changes should be made as PRs to this feature branch. This branch will have the same branch protections as main.
@Financial-Times/professional-lifecycle-experience will make changes will only do the following:
This PR will be blocked from merging into main. These changes are experimental and are owned by @Financial-Times/professional-lifecycle-experience. It is their responsibility to ensure the code works for the User Facing systems this code will be used for.
To release a beta version:
target
is set toCPP-1662-professional-enhance-search-collaboration
v9.0.0-beta.0
(and then increment the last digit, so the next release will bev9.0.0-beta.1
)Generate release notes button
)Set as a pre-release
Set as a latest release
When the experiment is done
The code for this experiment will not be merged into
main
. Once the A/B test is concluded, we should plan fresh how to enable enhance search into the Header with the idea it is used supported in Origami.