Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated german translations #732

Merged
merged 2 commits into from
May 24, 2024

Conversation

Bretterteig
Copy link
Contributor

@Bretterteig Bretterteig commented Apr 27, 2024

Description

Updated German translations. Key points:

  • Sort json object (equivalent to en.json)
  • Added all missing translations
  • Replaced Plex with {mediaServer} where applicable
  • Removed some deprecated key where newer apply

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthier-th gauthier-th changed the title Updated german translations feat: updated german translations May 24, 2024
Copy link
Owner

@Fallenbagel Fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be pedantic or anything but this should be a, refactor: conventional commit message metadata tag rather than feat:

Nvm commits aren't using the conventional commit messages just the title

@gauthier-th gauthier-th changed the title feat: updated german translations refactor: updated german translations May 24, 2024
@gauthier-th gauthier-th merged commit 461202d into Fallenbagel:develop May 24, 2024
7 checks passed
@Fallenbagel
Copy link
Owner

@all-contributors please add @Bretterteig for translation

Copy link
Contributor

@Fallenbagel

I've put up a pull request to add @Bretterteig! 🎉

Repository owner deleted a comment from allcontributors bot May 24, 2024
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants