Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blacklist items from Discover page #632

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JoaquinOlivero
Copy link
Contributor

@JoaquinOlivero JoaquinOlivero commented Jan 23, 2024

[Feature Request] Hide Items #490

Description

Allow users with special permissions to add media items to a blacklist to prevent them from being displayed.
The blacklist can be managed on the "Settings" page where media can be removed from it. In addition, if the user has permission to manage and view blacklisted items, there is a button on the movie/series card to remove it from the blacklist.

Screenshot (if UI-related)

output

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@Fallenbagel
Copy link
Owner

Fallenbagel commented Feb 23, 2024

Is this PR complete?
@JoaquinOlivero

@JoaquinOlivero
Copy link
Contributor Author

Is this PR complete? @JoaquinOlivero

Yes, it's complete

@Gauvino
Copy link
Contributor

Gauvino commented Feb 23, 2024

Then you should switch the PR from draft to Open ?

@Fallenbagel
Copy link
Owner

Is this PR complete? @JoaquinOlivero

Yes, it's complete

Okay I'm switching it to ready for review and I'll review it sometime this weekend c:

@Fallenbagel Fallenbagel marked this pull request as ready for review February 23, 2024 16:32
@Fallenbagel Fallenbagel self-requested a review as a code owner February 23, 2024 16:32
Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it the only missing point is the translation keys but everything else works fine !

Edit : How can I remove a blacklisted media from blacklist ? @JoaquinOlivero

<Modal
backgroundClickable
title={`Blacklist ${title}`}
subTitle="Are you sure you want to proceed?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the translation key please ?

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label May 23, 2024
Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Hide Items Reject !
3 participants