Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(courses): fix italian course page #6895

Merged
merged 2 commits into from
Jul 10, 2022
Merged

docs(courses): fix italian course page #6895

merged 2 commits into from
Jul 10, 2022

Conversation

LuigiImVector
Copy link
Member

@LuigiImVector LuigiImVector commented Jul 2, 2022 •
edited by davorpa

What does this PR do?

Improve repo

For resources

Description

  • Formatted the authors' name writed wrong
  • Removed the university name from the parenthesis:
  • before * [Name](url) - F. Corno (Politecnico di Torino) after * [Name](url) - F. Corno, Politecnico di Torino
  • Removed/changed broken link: lint: Broken links reported from urlchecker #5470
  • Replaced unaccepted links (urls with useless parameters...)
  • Moved/deleted resources

Notes

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@LuigiImVector
Copy link
Member Author

  • Removed the university name from the parenthesis

tell me if it's okay

@LuigiImVector LuigiImVector marked this pull request as draft July 2, 2022 13:05
@LuigiImVector LuigiImVector self-assigned this Jul 2, 2022
@LuigiImVector LuigiImVector added the 🗣️ locale:it Resources addressing "Italian / italiano" language label Jul 2, 2022
@LuigiImVector LuigiImVector added the 👀 Needs Review Is this really a good resource? Reviews requested. label Jul 2, 2022
@LuigiImVector LuigiImVector marked this pull request as ready for review July 2, 2022 16:16
@davorpa davorpa added the urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs. label Jul 3, 2022
@eshellman
Copy link
Collaborator

@mcicolella take a look. Formatting of the repo's lists is becoming more uniform to make the new search capability more useful.

@eshellman eshellman merged commit b2f788c into EbookFoundation:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LuigiImVector LuigiImVector

Labels
👀 Needs Review Is this really a good resource? Reviews requested. 🗣️ locale:it Resources addressing "Italian / italiano" language urlchecker Checker workflow monitoring the links of resources has found some warnings. See logs and fix URLs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LuigiImVector @eshellman @davorpa