Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Python tutorial at Tutorialspoint #4908

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Added Python tutorial at Tutorialspoint #4908

merged 4 commits into from
Nov 1, 2020

Conversation

Utkarsh299-tech
Copy link
Contributor

Hacktoberfest notes:

  • due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
  • please read our contributing guidelines
  • be sure to check the output of Travis-CI for linter errors
  • if this is your first open source contribution, make sure it's not your last!

What does this PR do?

Add Resource(s) | Remove Resource(s) | Add info | Improve Repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

SethFalco
SethFalco reviewed Oct 30, 2020
View reviewed changes
Copy link
Sponsor Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, and welcome to free programming books! 👋

Just a small comment, it helps keep the repository more consistent and tidy.

free-programming-interactive-tutorials-en.md Outdated
@@ -252,6 +252,7 @@
* [Python for Everybody - Interactive](https://runestone.academy/runestone/books/published/py4e-int/index.html) - Barbara Ericson
* [Python Koans](https://github.com/gregmalcolm/python_koans)
* [Python Tutorial](https://www.w3schools.com/python) - W3Schools
* [Python Tutorial](https://www.tutorialspoint.com/python) - Tutorialspoint
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write nouns with the correct capitalization, "Tutorials Point" is two words in title case.

Suggested change
* [Python Tutorial](https://www.tutorialspoint.com/python) - Tutorialspoint
* [Python Tutorial](https://www.tutorialspoint.com/python) - Tutorials Point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing this PR.
Okay sure, I will do that.

@eshellman
Copy link
Collaborator

we've been adding tutorials point content in courses and in books. See #4573 and comment if you think they should go into interactive tutorials.

@eshellman eshellman added the question Needs clarification by involved users / reviewers label Oct 30, 2020
@eshellman
Copy link
Collaborator

based on your comments, add them in books instead.

@Utkarsh299-tech
Copy link
Contributor Author

based on your comments, add them in books instead.
Hi @eshellman, as you said I added them to books. I hope it's good now.

@eshellman eshellman merged commit 1eb0746 into EbookFoundation:master Nov 1, 2020
@Utkarsh299-tech
Copy link
Contributor Author

Hi @eshellman thank you for merging this PR.
Can you add a 'hacktoberfest-accepted' label to it, please?

@SethFalco
Copy link
Sponsor Member

Hi @eshellman thank you for merging this PR.
Can you add a 'hacktoberfest-accepted' label to it, please?

There is no need for the label.

PRs only need to be merged, approved OR get the label.

Plus Hacktoberfest should be over by now.

@Utkarsh299-tech
Copy link
Contributor Author

Hi @eshellman thank you for merging this PR.
Can you add a 'hacktoberfest-accepted' label to it, please?

There is no need for the label.

PRs only need to be merged, approved OR get the label.

Plus Hacktoberfest should be over by now.

Okay, thank you for clearing my doubt.
And yes it's over now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethFalco SethFalco SethFalco left review comments

Assignees
No one assigned
Labels
question Needs clarification by involved users / reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Utkarsh299-tech @eshellman @SethFalco