Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize Windows types #357

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

GravisZro
Copy link
Contributor

@GravisZro GravisZro commented May 16, 2024

For whatever reason they decided to switch a bunch of Windows types to their underlying types which causes problems when replacing possibly problematic 32-bit long types. This restores the use of the Windows defined types.

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This is a type refactor, it doesn't impact how the code behaves.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Presently no overlap with PR #354

@GravisZro GravisZro marked this pull request as ready for review May 16, 2024 17:04
Copy link
Collaborator

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging when conflicts are solved (sorry, many other contributions went in first) and formatting is fixed

legacy/editor/TextureGrWnd.cpp Show resolved Hide resolved
For whatever reason they decided to switch a bunch of Windows types to their
underlying types which causes problems when replacing possibly problematic
32-bit long types. This restores the use of the Windows defined types.
@GravisZro
Copy link
Contributor Author

@Lgt2x My PRs are always treated like they are second-class. Everything else gets reviewed and merged before mine and then I have to fix my PRs repeatedly.

@Lgt2x
Copy link
Collaborator

Lgt2x commented May 23, 2024

@Lgt2x My PRs are always treated like they are second-class. Everything else gets reviewed and merged before mine and then I have to fix my PRs repeatedly.

I'm really sorry you feel that way; I tried to review PRs by order of creation yesterday. Your contributions are always welcome and very appreciated, I follow the same standards for every review.

@Lgt2x Lgt2x merged commit c28fc06 into DescentDevelopers:main May 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants