Static funcs

[MaddTheSane]

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

This more aggressively marks functions and variables as static, as well as marking some values as constexpr. Also included are a lot of comments, mainly remarking if a function is only used in one source file, or if it is unused in Descent 3 (and thus could probably be removed).

Related Issues

This patch does incorporate changes from #346. These can be reverted. A recent rebase removed the DallasFuncs changes.

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have documented any new or modified functionality.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Opened as a draft because this isn't complete, as well as wanting feedback about functions that aren't used by Descent 3 (either cut content incomplete features, or code that only used by the editor).

[Lgt2x]

Same as #346, we can revisit that when the internal editor is built for Windows. It uses a lot of functions from the game. Thanks for the effort anyways, I hope we can merge it sometime!

[bryanperris]

I approve the changes too