Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce coupling between headers associated to lanclient #343

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Reduce coupling between headers associated to lanclient #343

wants to merge 1 commit into from

Conversation

Lgt2x
Copy link
Collaborator

@Lgt2x Lgt2x commented May 13, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

  • mdllinit.h is now a standalone header instead of inline include
  • MULTI_USE_ALL_OPTIONS define is no more, decoupling con_dll.h from lanclient.cpp
  • con_dll.h has include guards and required includes to make it standalone

NEEDS THOROUGH MULTIPLAYER TESTING

@Lgt2x
Reduce coupling between headers associated to lanclient
b8301f3 
- mdllinit.h is now a standalone header instead of inline include
- MULTI_USE_ALL_OPTIONS define is no more, decoupling con_dll.h from lanclient.cpp
- con_dll.h has include guards and required includes to make it standalone
@Lgt2x Lgt2x marked this pull request as draft May 13, 2024 21:41
@Lgt2x Lgt2x added cleanup Code cleanup needs testing Needs testing to confirm issue or resolution labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup Code cleanup needs testing Needs testing to confirm issue or resolution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Lgt2x