Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch -useexedir #324

Closed
wants to merge 4 commits into from
Closed

Patch -useexedir #324

wants to merge 4 commits into from

Conversation

JeodC
Copy link
Collaborator

@JeodC JeodC commented May 9, 2024 •
edited

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Uses Base_directory[i] in the loop to correctly truncate the path.

Related Issues

#322

@JeodC
Patch -useexedir
d317fe5 
Fixe #322 by using `Base_directory[i]` in the loop to correctly truncate the path.
@JeodC JeodC mentioned this pull request May 9, 2024
Closed
20 tasks
@Lgt2x Lgt2x added the needs testing Needs testing to confirm issue or resolution label May 9, 2024
@JeodC
Copy link
Collaborator Author

JeodC commented May 9, 2024

Adds a partial improvement that does not fully resolve #322. Will test with windows later and merge if successful. #322 will need further improvements.

@JeodC
Copy link
Collaborator Author

JeodC commented May 9, 2024

@Lgt2x This does not work in windows either:

image

But the changes are still a step in the right direction. Should this be merged anyway or left open to be worked?

@Lgt2x
Copy link
Collaborator

Lgt2x commented May 9, 2024

@Lgt2x This does not work in windows either:

image

But the changes are still a step in the right direction. Should this be merged anyway or left open to be worked?

Base_directory seems to be wrong. Can you step with a debugger in the function to identify the problem?

@Lgt2x Lgt2x marked this pull request as draft May 13, 2024 20:03
@JeodC JeodC closed this May 19, 2024
@JeodC JeodC deleted the JeodC-patch-1 branch May 19, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lgt2x Lgt2x Lgt2x approved these changes

Assignees
No one assigned
Labels
needs testing Needs testing to confirm issue or resolution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeodC @Lgt2x