Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing installation steps #318

Merged
merged 1 commit into from
May 22, 2024
Merged

Introducing installation steps #318

merged 1 commit into from
May 22, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Added installation steps for all built targets. Added FORCE_PORTABLE_INSTALL cmake option that controls portable installation (only supported for now).

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

JeodC
JeodC reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@JeodC JeodC left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dependencies like fmt.dll and should also pack dmfc if it exists (separate PR open to build that).

Optional suggestion: Use legacy/D3Launch/res/D3Launch.ico as Descent3.ico and assign it directly to the binary.

Lgt2x
Lgt2x reviewed May 9, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@winterheart winterheart force-pushed the install-targets branch 2 times, most recently from 8b67553 to c680271 Compare May 12, 2024 20:31
@JeodC JeodC added documentation Improvements or additions to documentation build Modification to the build system and removed documentation Improvements or additions to documentation labels May 15, 2024
@winterheart winterheart mentioned this pull request May 22, 2024
Closed
13 tasks
Lgt2x
Lgt2x approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, local install and artifacts look correct. Merging when rebased

CMakeLists.txt Show resolved Hide resolved
@winterheart
Introducing installation steps
08b906f 
Added installation steps for all built targets. Added FORCE_PORTABLE_INSTALL cmake option that controls portable installation (only supported for now).
@winterheart
Copy link
Collaborator Author

Rebased.

@Lgt2x Lgt2x merged commit cdec632 into DescentDevelopers:main May 22, 2024
12 checks passed
@winterheart winterheart deleted the install-targets branch May 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeodC JeodC JeodC left review comments

@Lgt2x Lgt2x Lgt2x approved these changes

Assignees
No one assigned
Labels
build Modification to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@winterheart @Lgt2x @JeodC