Fix dmfc by partially reverting #219 #317
Conversation
|
Tested and verified working with windows. Needs tests from linux and macos. Connect to |
|
|
||
| # Don't build these yet | ||
| #add_subdirectory(anarchy) | ||
| #add_subdirectory(coop) | ||
| #add_subdirectory(ctf) | ||
| #add_subdirectory(entropy) | ||
| #add_subdirectory(hoard) | ||
| #add_subdirectory(hyperanarchy) | ||
| #add_subdirectory(monsterball) | ||
| #add_subdirectory(roboanarchy) | ||
| #add_subdirectory(tanarchy) |
There was a problem hiding this comment.
Why this code commented out?
There was a problem hiding this comment.
Because we are not building netgames yet. If we want to build them alongside dmfc, we need to fix them because when I last tried building them, they were broken (like d3c was).
There was a problem hiding this comment.
Well, I think, commenting them out is not related to intended partially reverting dmfc changes. Let's keep them building and resolve issues as they appears.
There was a problem hiding this comment.
Sure, and if I did the opposite someone else would complain that my PR ships broken code. This makes dmfc work with existing game assets. I advise a separate PR for fixing d3ms and subsequently turning them back on.
netgames/dmfc/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Question for linux and mac: on checking the steam depot for linux I can't find a dmfc library. Does this need to be static for those platforms? Windows wants it to be shared in order to function.
|
Dmfc is built as a static library on linux and mac. We should do the same for windows so there is consistency across the board. Marking this pull as a draft for rework. |
Pull Request Type
Description
#219 added virtual destructors to
netgames/includes/idmfc.h. This caused errors seen in #312. Comment these out for now, come back to fix later.Enforces building
dmfcbut does not build other netgames.Related Issues
Resolves #312