Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate "Direct TCP/IP.d3c" HOG file #302

Merged
merged 5 commits into from
May 8, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Related Issues

Fixes #300.

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Now HogMaker can be supplied with search paths where it tries to find files.
Add access to private fields and simplify HOG creation. HogFileEntry now contains path to real file that allows change its attributes internally.
Use new features of HogMaker.
Game expects a HOG file instead of direct library.
@winterheart winterheart added the multiplayer An issue with networking label May 7, 2024
@winterheart winterheart added this to the 1.5 Stable milestone May 7, 2024
Replaced CMAKE_BINARY_DIR with target's directory expression generator.
@winterheart
Copy link
Collaborator Author

Screenshot_20240507_212619

Multiplayer is playable on Linux but segfaults on exit. Need testing on Windows and macOS (need rename to .dylib?)

@winterheart
Copy link
Collaborator Author

Screenshot_20240507_213023

@winterheart winterheart requested review from JeodC and Arcnor May 7, 2024 18:33
Copy link
Collaborator

@JeodC JeodC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested extensively but I was able to connect to the 1.5 Upstream server provided by DescentMax. I flied around, shot some weapons, then exited without issue.

Unrelated to this, but related to multiplayer (#213), we will need to include dmfc.dll as a shared library in order for network loss and ping HUD elements to work properly--this may need to sync with the sever; I tried using a client-built dmfc.dll and I get crashes on join. The sever is likely using a 1.4 version of this library.

@JeodC JeodC merged commit bfb3fc1 into DescentDevelopers:main May 8, 2024
10 checks passed
@winterheart winterheart deleted the hog-tcp-ip branch May 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiplayer An issue with networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build Failure]: Built TCP-IP.d3c is not built correctly
2 participants