Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support case-insensitive loading of content files #294

Merged
merged 3 commits into from
May 6, 2024
Merged

Support case-insensitive loading of content files #294

merged 3 commits into from
May 6, 2024

Conversation

phlash
Copy link

@phlash phlash commented May 6, 2024 •
edited by JeodC

Pull Request Type

  • Runtime changes

Description

Supports loading content files in a case-insensitive manner, in particular HOG files and movies.

Related Issues

Fixes #262

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

Works for me with RandOmlY capitalisED HOG or movie files.

@phlash
Copy link
Author

phlash commented May 6, 2024

I think this is working for me now..

@phlash phlash marked this pull request as ready for review May 6, 2024 17:51
@phlash phlash changed the title Support case-insensitive loading of HOG files Support case-insensitive loading of content files May 6, 2024
Lgt2x
Lgt2x approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working on Linux for HOGs and movie files. @JeodC can you give it a go to make sure we didn't break anything on Windows unintentionally?

JeodC
JeodC approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@JeodC JeodC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows. Looks good.

@Lgt2x Lgt2x merged commit 3372c9b into DescentDevelopers:main May 6, 2024
10 checks passed
@phlash phlash deleted the case-insensitive-files branch May 9, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lgt2x Lgt2x Lgt2x approved these changes

@JeodC JeodC JeodC approved these changes

@jcoby jcoby Awaiting requested review from jcoby

@winterheart winterheart Awaiting requested review from winterheart

@jmarshall23 jmarshall23 Awaiting requested review from jmarshall23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Runtime Issue]: Case sensitive filesystems encountering errors
3 participants
@phlash @Lgt2x @JeodC