Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency-related corrections for Linux build instructions #259

Conversation

Jayman2000
Copy link
Contributor

@Jayman2000 Jayman2000 commented May 1, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This PR contains a few minor improvements to the build instructions for Linux. See the individual commits for details.

Fixes #267.

Related Issues

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

When the compilation instructions were first written [1], it made sense
to tell users to install the 32-bit version of libXext. At the time,
compiling Descent 3 on Linux required running a pre-compiled
hogUtils-i686 binary, and that binary depended on libXext.

As of 1765d07 (Remove now unused hogUtils-i686, 2024-04-21), the
hogUtils binary no longer exists, so there’s no need to install a 32-bit
version of libXext.

[1]: f929310 (Update README.md, 2024-04-20)
@Jayman2000 Jayman2000 force-pushed the build-instructions-dependency-corrections branch from 22b2768 to 67f1858 Compare May 2, 2024 01:33
@JeodC JeodC merged commit 1ce01c9 into DescentDevelopers:main May 2, 2024
@Jayman2000 Jayman2000 deleted the build-instructions-dependency-corrections branch May 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[README Issue]: package "spdlog-dev" does not exist
2 participants