Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logger on all CI builds #257

Merged
merged 1 commit into from May 3, 2024
Merged

Conversation

Lgt2x
Copy link
Collaborator

@Lgt2x Lgt2x commented May 1, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

No reason not to enable logging on all CI builds, it can help catch problems, and display useful information for executable artifacts

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@Lgt2x
Copy link
Collaborator Author

Lgt2x commented May 1, 2024

Automatic build not triggered, what did I do wrong...

@pzychotic
Copy link
Contributor

Automatic build not triggered, what did I do wrong...

I guess

    paths-ignore:
      - '**/README.md'
      - '**/LICENSE'
      - '**/.github/**'

prevents it because you only changed a file from the ignored paths and nothing else.

@Lgt2x
Copy link
Collaborator Author

Lgt2x commented May 1, 2024

Automatic build not triggered, what did I do wrong...

I guess

    paths-ignore:
      - '**/README.md'
      - '**/LICENSE'
      - '**/.github/**'

prevents it because you only changed a file from the ignored paths and nothing else.

oh thanks, this exclusion does make sense only for issues or PR templates, but not so much when you want to edit the workflow...

@JeodC JeodC added the workflow Modifications to the github workflows label May 2, 2024
@JeodC JeodC mentioned this pull request May 2, 2024
13 tasks
@JeodC
Copy link
Member

JeodC commented May 3, 2024

Merging for now, but will likely be replaced by workflow on cache branch pending #242

@JeodC JeodC merged commit ad78f4d into DescentDevelopers:main May 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow Modifications to the github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants