Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #4242 : Travis Build Status to Reflect Deployment Script Failures #4296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AishwaryJain07
Copy link

closes #4242
Implemented a fix to ensure Travis CI reports failures accurately during deployment.or push script fails!!

@codecov-commenter
Copy link

Codecov Report

Merging #4296 (dd3ee71) into master (96968d6) will decrease coverage by 3.63%.
Report is 1101 commits behind head on master.
The diff coverage is n/a.

❗ Current head dd3ee71 differs from pull request most recent head 9de78b4. Consider uploading reports for the commit 9de78b4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4296      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f705b19...9de78b4. Read the comment docs.

@AishwaryJain07
Copy link
Author

here i have implemented a || travis_terminate 1;
function to exit with code 1 whenever the code fails.
earlier it was giving exit 0 code even after build not successful, coz there was no condition to check, now i addressed it for both push and deploy

@AishwaryJain07
Copy link
Author

@gchhablani @gautamjajoo @Suryansh5545
can you please review this pr

@AishwaryJain07
Copy link
Author

@Suryansh5545 can you pleaese review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis Build Status to Reflect Deployment Script Failures
2 participants