-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a single point for "Check timeout expired" test result #63982
Conversation
This is an automated comment for commit 08be26a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
I think we should not backport such prs |
Why? Doesn't having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the goal?do you want to see "timeout expired" in commit status?
It's reasonable, but it's just my general feeling that it might be risky to spread changes like this across all release branches. If something goes wrong might be hard to hot fix it everywhere |
In that case, we'll fix it in master and backport again. Having up to 6 different CI, one modern and 5 deprecated, is a thing difficult to manage. |
maybe we can consider adding default timeout for all job as well, like 2h with fixing all jobs that do not fit (for another PR) |
Another place to touch is Clickbench #57712 |
I'll add timeout for ClickBench around 600 seconds, should be good |
Well, let's make it 900. It was very close to the end https://github.com/ClickHouse/ClickHouse/actions/runs/9129062303/job/25103116976#step:8:1743 |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make events like timeouts visible in CI DB
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: