-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer: Fix COLUMNS resolve #63962
Conversation
This is an automated comment for commit d7ff8f6 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
5214a75
to
d5b6903
Compare
last_day as ( select repo_name, count() as count_last_day, rowNumberInAllBlocks() + 1 as position_last_day from github_events where repo_name in (select repo_name from top_repos) and toDate(created_at) = today() - 1 group by repo_name order by count_last_day desc ), | ||
last_week as ( select repo_name, count() as count_last_week, rowNumberInAllBlocks() + 1 as position_last_week from github_events where repo_name in (select repo_name from top_repos) and toMonday(created_at) = toMonday(today()) - interval 1 week group by repo_name order by count_last_week desc ), | ||
last_month as ( select repo_name, count() as count_last_month, rowNumberInAllBlocks() + 1 as position_last_month from github_events where repo_name in (select repo_name from top_repos) and toStartOfMonth(created_at) = toStartOfMonth(today()) - interval 1 month group by repo_name order by count_last_month desc ) | ||
select d.repo_name, columns('count') from last_day d join last_week w on d.repo_name = w.repo_name join last_month m on d.repo_name = m.repo_name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix of the query. Before it was columns(count)
and now it is columns('count')
. Previously it expanded into 0 columns, but now it resolves into 3 columns.
…0973bf5afa86bd14d706e6d121fc3 Cherry pick #63962 to 23.8: Analyzer: Fix COLUMNS resolve
…0973bf5afa86bd14d706e6d121fc3 Cherry pick #63962 to 24.2: Analyzer: Fix COLUMNS resolve
…0973bf5afa86bd14d706e6d121fc3 Cherry pick #63962 to 24.3: Analyzer: Fix COLUMNS resolve
…0973bf5afa86bd14d706e6d121fc3 Cherry pick #63962 to 24.4: Analyzer: Fix COLUMNS resolve
Backport #63962 to 24.3: Analyzer: Fix COLUMNS resolve
Backport #63962 to 24.4: Analyzer: Fix COLUMNS resolve
Backport #63962 to 24.2: Analyzer: Fix COLUMNS resolve
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix resolve of unqualified COLUMNS matcher. Preserve the input columns order and forbid usage of unknown identifiers.
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: