Disable pretty format restrictions when stdout is not TTY #63942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-not-for-changelog
|
This is an automated comment for commit 4348168 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
antaljanosbenjamin
approved these changes
May 16, 2024
|
Is it okay for you to change category to |
Sure, done. |
|
How to apply these limits when stdout is a tty? Needs a compatibility setting. |
If it is, then they simply works, this is just an overrides to make the output unlimited in case of i.e. |
I will apply the following hack for this - 8b61531 with a hope that it is not too ugly, but I don't have better idea (though later I think we could slightly rework how --interactive is handled for client, but let's not mix this changes in one PR) |
robot-ch-test-poll3
added
pr-improvement
But no proper stacktraces due to musl build... Will do a rebase |
azat
force-pushed
the
client-pretty-format-tty-only
branch
from
8b61531
to
f865b7b
Compare
|
If I want to redirect the output but still apply the same limits, how could it be done? |
|
Pass them explicitly, since they adjusted only if not changed |
alexey-milovidov
approved these changes
May 18, 2024
30 tasks
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
settings changes check simply checks that the settings are either the same, or there is a record in system.settings_changes, however, the problem is that clickhouse-local now adjusts some settings for Pretty format in case of stdout is not a tty, and this is the case for this check. So to avoid this, just run the clickhouse-local under script(1) to fool it. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
client-pretty-format-tty-only
branch
from
f865b7b
to
4348168
Compare
|
robot-ch-test-poll1
added
the
pr-synced-to-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable pretty format restrictions (
output_format_pretty_max_rows/output_format_pretty_max_value_width) when stdout is not TTY