Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added threadId to Feedback #999

Merged
merged 1 commit into from
May 18, 2024

Conversation

mayaankvad
Copy link
Contributor

Added threadId to Feedback. This will allow for getting the associated threadId easily. Plan to use this in adding document database data layers to chainlit like Dynamo. Discussed with @willydouhard

@willydouhard
Copy link
Collaborator

I think this is great! This does not update the data layers but this is probably out of scope. I assume you are using a custom data layer yourself?

@mayaankvad
Copy link
Contributor Author

mayaankvad commented May 18, 2024

Yes I wanted to keep this PR small. The literal and sql data layers also don't need to use the threadId property so there was no reason to update them. I can make another PR to add those properties to the sql layer (but that might require everyone using it to update their table schema on chainlit upgrade), let me know if this is something you want me to look into.

I am working on a custom data layer that needs the threadId, so I wanted to add this change in preparation for that PR.

@willydouhard willydouhard merged commit aa1f722 into Chainlit:main May 18, 2024
4 checks passed
@mayaankvad mayaankvad deleted the feature/pass-threadId branch May 19, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants