Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve #828 by updating websocket's thread id header with currentThreadId to ensure session continuation after backend restart #996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qtangs
Copy link
Contributor

@qtangs qtangs commented May 15, 2024

Resolve #828 by updating websocket's thread id header with currentThreadId to ensure session continuation after backend restart #996

Changes:

  • Update websocket headers to use currentThreadId when it's updated
  • Modify data_layer test to save thread history for reload after backend restarts
  • Add new test to ensure the thread is resumed properly with correct state and also ensure that new threads after restart work as before.

…th currentThreadId to ensure session continuation after backend restart
@willydouhard
Copy link
Collaborator

This looks really nice, will run a couple more tests before merging. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend/react-client does not resume session after backend connection loss
2 participants