SQS cleanup (tables and apps) #13689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sure the DB is cleared of any unused tables or rows.
…re similar to table save.
…ect Couch call functionality.
…on, making sure it cannot be missed.
adrinr
reviewed
May 15, 2024
| const db = context.getAppDB() | ||
| const tableId = table._id! | ||
| // remove table search index | ||
| if (!env.isTest() || env.COUCH_DB_URL) { |
There was a problem hiding this comment.
Shouldn't this be checking if there sqs is enabled, instead of env.COUCH_DB_URL?
There was a problem hiding this comment.
What is the reason why this is excluded from tests?
There was a problem hiding this comment.
honestly, I'm not sure - I didn't add this/change it, the indexes stuff is very old (and unrelated to SQS) that probably needs removed, I just moved it all to a central location for internal table cleanup, rather than it being splattered throughout the table controller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQS automatically syncs data from CouchDB that comes via the changes stream, however when tables are deleted or when an app database is deleted it is not fully aware of this.
Keeping this information will not cause any search problems, but would use extra disk space that could be freed up. This solves the problem by making sure when a DB is removed that the on disk status is cleaned up, as well as making sure when a table is deleted it is removed from the SQLite design schema.
Sadly this is quite hard to test as SQS was already aware that rows/DB doesn't exist anymore, so won't respond to the search with them, the only way to confirm that this has worked as expected is by confirming the SQLite databases have been removed from the disk. I've checked/confirmed this and it does appear to be working as expected.
Addresses