modernize composable architecture syntax

[ZevEisenberg]

Resolves warnings in example project that were introduced when TCA was updated to 0.26.0 or higher.

[ohitsdaniel]

I think we need to update TCA in the example project to get this to pass on CI. Could you Update to latest package versions in the workspace and commit the Lockfile changes? :)

[ZevEisenberg]

I did, and got no Git changes, and Xcode is showing me TCA 0.28.1. I'll try bumping the version in the Package.swift and see if that helps?

[ohitsdaniel]

https://github.com/Bahn-X/swift-composable-navigator/runs/4085428175?check_suite_focus=true#step:5:86

According to the looks, CI uses 0.28.1 as well. I'll check later tonight why CI fails (in roughly 3 hours), my first assumption was wrong, sorry!

[ZevEisenberg]

Bumped TCA in Package.swift to 0.28.0+ before seeing your message. Feel free to revert if that's not helpful; it looks like that would update it for the whole library, so probably more invasive than you want. I didn't see a way to update it for just the example project.

Anyway, this isn't blocking me or anything, just noticed the warnings while looking at something else in the example project. Thanks for looking at it 😄

[ZevEisenberg]

Aha:

// NB: `BindableAction` can produce crashes in Xcode 12.4 (Swift 5.3) and earlier due to an enum
//     protocol witness bug: https://bugs.swift.org/browse/SR-14041
#if compiler(>=5.4)

[ZevEisenberg]

(And tests are running on Xcode 12.4.)

[ohitsdaniel]

Ah, thanks for investigating! Guess it's time to bump CI to Xcode 13. 🙈

[ZevEisenberg]

I'm using 12.5, fwiw. But yes 😊