Maint: Show Cmd + K for macOS users
#1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckrnx09
commented
May 15, 2024
| @@ -12,6 +12,10 @@ export interface TreeSearchProps { | |||
| feeds: Subscription[] | |||
| } | |||
|
|
|||
| function isMacOS() { | |||
| return navigator.platform.toUpperCase().includes("MAC") | |||
There was a problem hiding this comment.
luckrnx09
force-pushed
the
luckrnx09-cmd-k-for-macos-users
branch
from
6c4b4c0
to
884516b
Compare
|
Thank you, that's a nice addition. Could you update the Keyboard Shortcuts help page in KeyboardShortcutsHelp.tsx too please? Also, there seems to be a helper in mantine to detect the user OS, I think it would be nice to use it since it seems to be more robust. |
Thanks @Athou , mantine is great! I used the |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.