feat(datasets): add span to dataset from the trace page #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mikeldking
force-pushed
the
3208-add-span-to-dataset
branch
from
c24f5bf
to
83ba9ac
Compare
mikeldking
changed the title
mikeldking
force-pushed
the
3208-add-span-to-dataset
branch
from
d695dc1
to
f63691b
Compare
mikeldking
force-pushed
the
3208-add-span-to-dataset
branch
from
91fca21
to
af2dc70
Compare
dosubot
bot
added
the
size:XL
axiomofjoy
reviewed
May 24, 2024
axiomofjoy
approved these changes
May 24, 2024
| }) => ( | ||
| <Card | ||
| title="Metadata" | ||
| subTitle="All data from the span to use during experimentation or evaluation" |
There was a problem hiding this comment.
Suggested change
| subTitle="All data from the span to use during experimentation or evaluation" | |
| subTitle="Span attributes that can be used during experimentation or evaluation" |
|
Noticing we don't have a close button on this slideover like we do for other slideovers.
|
Co-authored-by: Xander Song <axiomofjoy@gmail.com>
Co-authored-by: Xander Song <axiomofjoy@gmail.com>
Co-authored-by: Xander Song <axiomofjoy@gmail.com>
|
works on my machine? Let me check with you later. |
mikeldking
added a commit
that referenced
this pull request
Jun 1, 2024
* feat(datasets): add span to dataset * structer guidelines * Add tests * add tests * Update app/src/pages/trace/SpanToDatasetExampleDialog.tsx Co-authored-by: Xander Song <axiomofjoy@gmail.com> * Update app/src/pages/trace/SpanToDatasetExampleDialog.tsx Co-authored-by: Xander Song <axiomofjoy@gmail.com> * Update app/src/pages/trace/SpanToDatasetExampleDialog.tsx Co-authored-by: Xander Song <axiomofjoy@gmail.com> --------- Co-authored-by: Xander Song <axiomofjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3208
Adds the ability to add a span to a dataset.Has some follow-up UI elements that will be filed separately.