feat: add graphql resolver for adding spans to datasets #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
axiomofjoy
force-pushed
the
add-span-to-dataset
branch
2 times, most recently
from
f56f7b5
to
a149c32
Compare
axiomofjoy
commented
May 17, 2024
dosubot
bot
added
the
size:XL
|
can you rebase this on top of datasets? |
Gonna squash merge, though? |
mikeldking
approved these changes
May 17, 2024
axiomofjoy
force-pushed
the
add-span-to-dataset
branch
from
f72d4ee
to
03d1e29
Compare
|
Rebased. |
mikeldking
pushed a commit
that referenced
this pull request
May 20, 2024
mikeldking
pushed a commit
that referenced
this pull request
May 21, 2024
mikeldking
pushed a commit
that referenced
this pull request
Jun 1, 2024
mikeldking
pushed a commit
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
addsSpansToDatasetGraphQL resolver. I'm going to refactor our mutations into separate modules after landing this PR.resolves #3178