feat: Able to override settings for workspace through .androidide/settings.json inside project #1788
Conversation
…tings.json inside project
|
I haven't added to customize the action for the app, for example override the task in quick run menu: {
"action.quickRun": "bash gradlew run"
}Because you said that it could be a huge security vulnerability. But I'll add it also if you say. |
|
And I have only added a few editor settings because I don't think all the settings are necessary. |
| completionsMatchLower = workspaceSettings.completionsMatchLower | ||
| drawLeadingWs = workspaceSettings.drawLeadingWs | ||
| drawTrailingWs = workspaceSettings.drawTrailingWs | ||
| drawInnerWs = workspaceSettings.drawInnerWs | ||
| drawEmptyLineWs = workspaceSettings.drawEmptyLineWs | ||
| drawLineBreak = workspaceSettings.drawLineBreak | ||
| fontSize = workspaceSettings.fontSize | ||
| tabSize = workspaceSettings.tabSize | ||
| autoSave = workspaceSettings.autoSave | ||
| fontLigatures = workspaceSettings.fontLigatures | ||
| visiblePasswordFlag = workspaceSettings.visiblePasswordFlag | ||
| wordwrap = workspaceSettings.wordwrap | ||
| useSoftTab = workspaceSettings.useSoftTab | ||
| deleteTabsOnBackspace = workspaceSettings.deleteTabsOnBackspace | ||
| stickyScrollEnabled = workspaceSettings.stickyScrollEnabled | ||
| pinLineNumbers = workspaceSettings.pinLineNumbers |
There was a problem hiding this comment.
This approach is incorrect. You're updating the global IDE preferences here, which will affect other projects as well.
There was a problem hiding this comment.
Other project will be affected only once and next time that project also has its own settings.json file then it will be applied while opening the project.
There was a problem hiding this comment.
It must not affect anything other than the preferences for that specific project.
app/src/main/java/com/itsaky/androidide/viewmodel/EditorViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/itsaky/androidide/activities/editor/EditorHandlerActivity.kt
Outdated
Show resolved
Hide resolved
fixes (#1674)