[HackerOne-2485380] Prevent DOS by limiting sent requests to one per peer #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
ljedrz
reviewed
May 16, 2024
howardwu
approved these changes
May 23, 2024
vicsn
added a commit
to AleoHQ/snarkOS
that referenced
this pull request
May 28, 2024
…nd-requests"" This reverts commit 01f1b86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to solve a DOS vector that is outlined in #3243, where a malicious validator can fill up the
max_redundant_requestsand not respond. This PR adjusts the rules so that we only send one request for that item to a given peer at a time.This means that
max_redundant_requestscan only be reached with unique peers. And becausemax_redundant_requestsis based on the availability threshold you can expect at least one node to be honest.Test Plan
A test has been added to ensure that the functionality of
contains_peer_with_sent_requestis as intended.